Skip to content

[Avatar] Fix initials overflowing when round #9295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023
Merged

[Avatar] Fix initials overflowing when round #9295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eight-windows-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed `initials` overflowing when `Avatar` is round
4 changes: 2 additions & 2 deletions polaris-react/src/components/Avatar/Avatar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
}

.Text {
font-size: var(--p-font-size-300);
font-size: var(--p-font-size-200);
font-weight: var(--p-font-weight-regular);

&.long {
font-size: var(--p-font-size-100);
font-size: var(--p-font-size-75);
}
}

Expand Down
28 changes: 16 additions & 12 deletions polaris-react/src/components/Avatar/Avatar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ export function Default() {
return <Avatar customer name="Farrah" />;
}

export function LongInitials() {
return <Avatar initials="WWW" name="Woluwayemisi Wolu Weun-Jung" />;
}

export function ExtraSmall() {
const [active, setActive] = useState(true);
const toggleActive = useCallback(() => setActive((active) => !active), []);
Expand Down Expand Up @@ -67,32 +71,32 @@ export function SquareWithInitials() {
<LegacyStack.Item>
<Avatar
shape="square"
initials="OE"
name="Oluwayemisi Eun-Jung"
initials="WW"
name="Woluwayemisi Weun-Jung"
size="extraSmall"
/>
</LegacyStack.Item>
<LegacyStack.Item>
<Avatar
shape="square"
initials="OE"
name="Oluwayemisi Eun-Jung"
initials="WW"
name="Woluwayemisi Weun-Jung"
size="small"
/>
</LegacyStack.Item>
<LegacyStack.Item>
<Avatar
shape="square"
initials="OE"
name="Oluwayemisi Eun-Jung"
initials="WW"
name="Woluwayemisi Weun-Jung"
size="medium"
/>
</LegacyStack.Item>
<LegacyStack.Item>
<Avatar
shape="square"
initials="OE"
name="Oluwayemisi Eun-Jung"
initials="WW"
name="Woluwayemisi Weun-Jung"
size="large"
/>
</LegacyStack.Item>
Expand Down Expand Up @@ -123,16 +127,16 @@ export function SizesWithInitials() {
return (
<LegacyStack vertical>
<LegacyStack.Item>
<Avatar initials="OE" name="Oluwayemisi Eun-Jung" size="extraSmall" />
<Avatar initials="WW" name="Woluwayemisi Weun-Jung" size="extraSmall" />
</LegacyStack.Item>
<LegacyStack.Item>
<Avatar initials="OE" name="Oluwayemisi Eun-Jung" size="small" />
<Avatar initials="WW" name="Woluwayemisi Weun-Jung" size="small" />
</LegacyStack.Item>
<LegacyStack.Item>
<Avatar initials="OE" name="Oluwayemisi Eun-Jung" size="medium" />
<Avatar initials="WW" name="Woluwayemisi Weun-Jung" size="medium" />
</LegacyStack.Item>
<LegacyStack.Item>
<Avatar initials="OE" name="Oluwayemisi Eun-Jung" size="large" />
<Avatar initials="WW" name="Woluwayemisi Weun-Jung" size="large" />
</LegacyStack.Item>
</LegacyStack>
);
Expand Down
3 changes: 3 additions & 0 deletions polaris.shopify.com/content/components/images-and-icons/avatar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ examples:
- fileName: avatar-default.tsx
title: Default
description: Use to present an avatar for a merchant, customer, or business.
- fileName: avatar-initials.tsx
title: Initials
description: Use to present an avatar with initials for a merchant, customer, or business.
- fileName: avatar-extra-small.tsx
title: Extra small
description: Use to present an avatar in a condensed layout, such as a data table cell or an action list item.
Expand Down
9 changes: 9 additions & 0 deletions polaris.shopify.com/pages/examples/avatar-initials.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import {Avatar} from '@shopify/polaris';
import React from 'react';
import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function AvatarExample() {
return <Avatar initials="WW" name="Woluwayemisi Weun-Jung" />;
}

export default withPolarisExample(AvatarExample);