Skip to content

Conversation

kvendrik
Copy link
Member

@kvendrik kvendrik commented Jan 24, 2019

WHY are these changes introduced?

Follow up on #887. Deprecates the userMenu prop on Navigation as with the deprecation of Navigation.UserMenu it won't be needed anymore.

WHAT is this pull request doing?

Adds the appropriate deprecation messages to the component.

How to 🎩

  1. Mount a <Navigation /> component in the playground.
  2. Make sure no deprecation messages show up in the console.
  3. Add a userMenu to the <Navigation />.
  4. Make sure the userMenu deprecation notice shows up in the console.
Playground code
import * as React from 'react';
import {Page, Navigation} from '../src';

interface State {}

export default class Playground extends React.Component<{}, State> {
  render() {
    return (
      <Page title="Playground">
        <Navigation location="" userMenu={<div />} />
      </Page>
    );
  }
}

@BPScott BPScott temporarily deployed to polaris-react-pr-930 January 24, 2019 15:43 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-930 January 24, 2019 15:44 Inactive
Co-Authored-By: kvendrik <k.vendrik@gmail.com>
@kvendrik kvendrik merged commit 5e50e41 into master Jan 30, 2019
@kvendrik kvendrik deleted the deprecate-navigation-usermenu branch January 30, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants