Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-pumpkins-approve.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Added internationalized accessibility label to Banner dismiss button
3 changes: 3 additions & 0 deletions polaris-react/locales/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@
"cancel": "Zrušit"
}
}
},
"Banner": {
"dismissButton": "Zavřít notifikaci"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/da.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Annuller"
}
}
},
"Banner": {
"dismissButton": "Afvis meddelelse"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Abbrechen"
}
}
},
"Banner": {
"dismissButton": "Benachrichtigung verwerfen"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
},
"progressAndStatus": "{statusLabel} {progressLabel}"
},
"Banner": {
"dismissButton": "Dismiss notification"
},
"Button": {
"spinnerAccessibilityLabel": "Loading",
"connectedDisclosureAccessibilityLabel": "Related actions"
Expand Down
3 changes: 3 additions & 0 deletions polaris-react/locales/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@
"cancel": "Cancelar"
}
}
},
"Banner": {
"dismissButton": "Descartar notificación"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/fi.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Peruuta"
}
}
},
"Banner": {
"dismissButton": "Ohita ilmoitus"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@
"cancel": "Annuler"
}
}
},
"Banner": {
"dismissButton": "Rejeter la notification"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@
"cancel": "Annulla"
}
}
},
"Banner": {
"dismissButton": "Elimina notifica"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "キャンセル"
}
}
},
"Banner": {
"dismissButton": "通知を閉じる"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "취소"
}
}
},
"Banner": {
"dismissButton": "알림 무시"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/nb.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Avbryt"
}
}
},
"Banner": {
"dismissButton": "Avvis varsel"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Annuleren"
}
}
},
"Banner": {
"dismissButton": "Melding sluiten"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/pl.json
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@
"cancel": "Anuluj"
}
}
},
"Banner": {
"dismissButton": "Odrzuć powiadomienie"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@
"cancel": "Cancelar"
}
}
},
"Banner": {
"dismissButton": "Dispensar notificação"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/pt-PT.json
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@
"cancel": "Cancelar"
}
}
},
"Banner": {
"dismissButton": "Ignorar notificação"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/sv.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Avbryt"
}
}
},
"Banner": {
"dismissButton": "Avvisa avisering"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/th.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "ยกเลิก"
}
}
},
"Banner": {
"dismissButton": "ปิดการแจ้งเตือน"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/tr.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "İptal"
}
}
},
"Banner": {
"dismissButton": "Bildirimi kapat"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "Hủy"
}
}
},
"Banner": {
"dismissButton": "Bỏ qua thông báo"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "取消"
}
}
},
"Banner": {
"dismissButton": "忽略通知"
}
}
}
3 changes: 3 additions & 0 deletions polaris-react/locales/zh-TW.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,9 @@
"cancel": "取消"
}
}
},
"Banner": {
"dismissButton": "關閉通知"
}
}
}
2 changes: 1 addition & 1 deletion polaris-react/src/components/Banner/Banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export const Banner = forwardRef<BannerHandles, BannerProps>(function Banner(
plain
icon={CancelSmallMinor}
onClick={onDismiss}
accessibilityLabel="Dismiss notification"
accessibilityLabel={i18n.translate('Polaris.Banner.dismissButton')}
/>
</div>
);
Expand Down