-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add optimize script #9580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add optimize script #9580
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@shopify/polaris-icons': minor | ||
| --- | ||
|
|
||
| Added optimize script |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| module.exports = { | ||
| plugins: [ | ||
| { | ||
| name: 'preset-default', | ||
| params: { | ||
| overrides: { | ||
| /** | ||
| * viewBox is needed in order to produce 20px by 20px containers | ||
| * with smaller (minor) icons inside. | ||
| */ | ||
| removeViewBox: false, | ||
|
|
||
| /** | ||
| * The following 2 settings are disabled to reduce rendering inconsistency | ||
| * on Android. Android uses a subset of the SVG spec called SVG Tiny: | ||
| * https://developer.android.com/studio/write/vector-asset-studio#svg-support | ||
| */ | ||
|
|
||
| /** | ||
| * Merging mutliple detached paths into a single path can lead to | ||
| * rendering issues on some platforms where detatched paths are joined | ||
| * by hairlines. Not merging paths results in greater compatibility | ||
| * with minimal additional overhead. | ||
| */ | ||
| mergePaths: false, | ||
|
|
||
| convertPathData: { | ||
| /** | ||
| * Mixing absolute and relative path commands can lead to rendering | ||
| * issues on some platforms. This disables converting some path data to | ||
| * absolute if it is shorter, keeping all path data relative. Using | ||
| * relative paths means that data points are relative to the current | ||
| * point at the start of the path command, which does not greatly | ||
| * increase the quantity of path data. | ||
| */ | ||
| utilizeAbsolute: false, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up @kyledurand and @samrose3, I don't think
yarnis needed here.svgo's bin script should automatically be symlinked tonode_modules/.binand thus available to the run-script:See here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch and great point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!