Skip to content

[Icons] Add social media icons #9777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2023
Merged

[Icons] Add social media icons #9777

merged 5 commits into from
Jul 21, 2023

Conversation

@heyjoethomas
Copy link
Contributor

@heyjoethomas heyjoethomas commented Jul 20, 2023

WHY are these changes introduced?

We need a way to represent common social media platforms within the admin.

WHAT is this pull request doing?

This PR simply adds minor icons for 7 of the most common social media platforms.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@heyjoethomas heyjoethomas self-assigned this Jul 20, 2023
kyledurand
kyledurand approved these changes Jul 21, 2023
View reviewed changes
@heyjoethomas @kyledurand
Update polaris-icons/icons/InstagramMinor.svg
6ad6307 
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
@heyjoethomas heyjoethomas merged commit 8228de0 into main Jul 21, 2023
@heyjoethomas heyjoethomas deleted the social-media-icons branch July 21, 2023 15:44
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 21, 2023
Merged
mattkubej pushed a commit that referenced this pull request Jul 21, 2023
@shopify-github-actions-access @github-actions
Version Packages (#9778)
e956178 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.6.0

### Minor Changes

- [#9777](#9777)
[`8228de0f6`](8228de0)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Added social
media icons

## @shopify/polaris@11.9.0

### Minor Changes

- [#9761](#9761)
[`ce3e516a2`](ce3e516)
Thanks [@aveline](https://github.com/aveline)! - Added `readOnly` prop
to `Labelled` component


- [#9770](#9770)
[`571acc166`](571acc1)
Thanks [@zaquille-oneil](https://github.com/zaquille-oneil)! - Updating
TextField to support ArrowUp and ArrowDown keypresses for "integer" type

### Patch Changes

- [#9765](#9765)
[`541e5920b`](541e592)
Thanks [@mattkubej](https://github.com/mattkubej)! - [TopBar] convert to
grid and center align search field

- Updated dependencies
\[[`8228de0f6`](8228de0)]:
    -   @shopify/polaris-icons@7.6.0

## @shopify/polaris-cli@0.2.24



## polaris.shopify.com@0.56.2

### Patch Changes

- Updated dependencies
\[[`ce3e516a2`](ce3e516),
[`8228de0f6`](8228de0),
[`571acc166`](571acc1),
[`541e5920b`](541e592)]:
    -   @shopify/polaris@11.9.0
    -   @shopify/polaris-icons@7.6.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@heyjoethomas @kyledurand @juzser
[Icons] Add social media icons (Shopify#9777)
4f0b0ad 
### WHY are these changes introduced?

We need a way to represent common social media platforms within the
admin.


### WHAT is this pull request doing?
This PR simply adds minor icons for 7 of the most common social media
platforms.

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#9778)
8149966 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.6.0

### Minor Changes

- [Shopify#9777](Shopify#9777)
[`8228de0f6`](Shopify@8228de0)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Added social
media icons

## @shopify/polaris@11.9.0

### Minor Changes

- [Shopify#9761](Shopify#9761)
[`ce3e516a2`](Shopify@ce3e516)
Thanks [@aveline](https://github.com/aveline)! - Added `readOnly` prop
to `Labelled` component


- [Shopify#9770](Shopify#9770)
[`571acc166`](Shopify@571acc1)
Thanks [@zaquille-oneil](https://github.com/zaquille-oneil)! - Updating
TextField to support ArrowUp and ArrowDown keypresses for "integer" type

### Patch Changes

- [Shopify#9765](Shopify#9765)
[`541e5920b`](Shopify@541e592)
Thanks [@mattkubej](https://github.com/mattkubej)! - [TopBar] convert to
grid and center align search field

- Updated dependencies
\[[`8228de0f6`](Shopify@8228de0)]:
    -   @shopify/polaris-icons@7.6.0

## @shopify/polaris-cli@0.2.24



## polaris.shopify.com@0.56.2

### Patch Changes

- Updated dependencies
\[[`ce3e516a2`](Shopify@ce3e516),
[`8228de0f6`](Shopify@8228de0),
[`571acc166`](Shopify@571acc1),
[`541e5920b`](Shopify@541e592)]:
    -   @shopify/polaris@11.9.0
    -   @shopify/polaris-icons@7.6.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@heyjoethomas @kyledurand
[Icons] Add social media icons (Shopify#9777)
920f1c3 
### WHY are these changes introduced?

We need a way to represent common social media platforms within the
admin.


### WHAT is this pull request doing?
This PR simply adds minor icons for 7 of the most common social media
platforms.

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@shopify-github-actions-access @github-actions
Version Packages (Shopify#9778)
7fb9040 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@7.6.0

### Minor Changes

- [Shopify#9777](Shopify#9777)
[`8228de0f6`](Shopify@920f1c3)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Added social
media icons

## @shopify/polaris@11.9.0

### Minor Changes

- [Shopify#9761](Shopify#9761)
[`ce3e516a2`](Shopify@4ac8815)
Thanks [@aveline](https://github.com/aveline)! - Added `readOnly` prop
to `Labelled` component


- [Shopify#9770](Shopify#9770)
[`571acc166`](Shopify@6ff428e)
Thanks [@zaquille-oneil](https://github.com/zaquille-oneil)! - Updating
TextField to support ArrowUp and ArrowDown keypresses for "integer" type

### Patch Changes

- [Shopify#9765](Shopify#9765)
[`541e5920b`](Shopify@7040c61)
Thanks [@mattkubej](https://github.com/mattkubej)! - [TopBar] convert to
grid and center align search field

- Updated dependencies
\[[`8228de0f6`](Shopify@920f1c3)]:
    -   @shopify/polaris-icons@7.6.0

## @shopify/polaris-cli@0.2.24



## polaris.shopify.com@0.56.2

### Patch Changes

- Updated dependencies
\[[`ce3e516a2`](Shopify@4ac8815),
[`8228de0f6`](Shopify@920f1c3),
[`571acc166`](Shopify@6ff428e),
[`541e5920b`](Shopify@7040c61)]:
    -   @shopify/polaris@11.9.0
    -   @shopify/polaris-icons@7.6.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand approved these changes

@zecarlostorre zecarlostorre zecarlostorre approved these changes

Assignees

@heyjoethomas heyjoethomas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyjoethomas @kyledurand @zecarlostorre