Close any database connections at the end of request #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to reuse database connections for the LSP server, as the overhead of establishing new connections locally is negligible. Therefore, we can close any active database connections as soon as we're done with the request.
janko
force-pushed
the
disconnect-from-database
branch
from
1ad7415 to
9593a30
Compare
janko
changed the title
vinistock
approved these changes
Nov 11, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Nice. Thanks for the contribution!
I measured locally and the price we pay for having to establish the connection every time is around 2ms, so I think it should be fine.
We also have no way of selectively dropping the connection. I believe this is the way to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to reuse database connections for the LSP server, as the overhead of establishing new connections locally is negligible, and the schema cache remains populated even after disconnect. Therefore, we can close any active database connections as soon as we're done with the request.
Closes #536