Ensure we index non test files under test directories #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
vinistock
force-pushed
the
02-12-ensure_we_index_non_test_files_under_test_directories
branch
6 times, most recently
from
0e44b1d to
af8bce2
Compare
andyw8
approved these changes
Feb 19, 2025
vinistock
force-pushed
the
02-12-ensure_we_index_non_test_files_under_test_directories
branch
from
af8bce2 to
d296f6c
Compare
Merge activity
|
### Motivation I noticed something with #3180. We can only accurately linearize ancestors for test files if we index files under the test directories that aren't tests, but support implementations. For example, in our own codebase, we have `lib/ruby_indexer/test/test_case.rb`, which is not a test, but implements the parent class for all tests in the indexer. If we never index that parent class, it's impossible to linearize the ancestors of any of the tests and we can't discover them properly. ### Implementation I propose we start indexing non test files inside the test directory. In addition to allowing our improved test functionality to work, users often refer to these support declarations when writing the tests themselves. I also simplified the code, which was hard to follow, while still trying to maintain the original performance gains applied by recent changes. One small thing is that I couldn't think of a decent way to not exclude `test_case` and `test_helper` from indexing, since both of them are common names that may declare test parent classes and match our file exclusion glob. I created a special case to handle them. I benchmarked this and it makes no substantial difference in indexing time in Core. ### Automated Tests Added a test verifying the behaviour changes.
graphite-app
bot
force-pushed
the
02-12-ensure_we_index_non_test_files_under_test_directories
branch
from
d296f6c to
e458a40
Compare
graphite-app
bot
deleted the
02-12-ensure_we_index_non_test_files_under_test_directories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed something with #3180. We can only accurately linearize ancestors for test files if we index files under the test directories that aren't tests, but support implementations.
For example, in our own codebase, we have
lib/ruby_indexer/test/test_case.rb, which is not a test, but implements the parent class for all tests in the indexer. If we never index that parent class, it's impossible to linearize the ancestors of any of the tests and we can't discover them properly.Implementation
I propose we start indexing non test files inside the test directory. In addition to allowing our improved test functionality to work, users often refer to these support declarations when writing the tests themselves.
I also simplified the code, which was hard to follow, while still trying to maintain the original performance gains applied by recent changes.
One small thing is that I couldn't think of a decent way to not exclude
test_caseandtest_helperfrom indexing, since both of them are common names that may declare test parent classes and match our file exclusion glob. I created a special case to handle them.I benchmarked this and it makes no substantial difference in indexing time in Core.
Automated Tests
Added a test verifying the behaviour changes.