Add test discovery support for Minitest spec style syntax #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrocha
added
enhancement
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
andyw8
reviewed
Feb 21, 2025
|
Let's update the PR title indicate that this applies to test discovery (since we already support spec syntax in other places, such as Code Lens). |
andyw8
reviewed
Feb 21, 2025
andyw8
reviewed
Feb 21, 2025
andyw8
reviewed
Feb 21, 2025
andyw8
reviewed
Feb 21, 2025
andyw8
reviewed
Feb 21, 2025
andyw8
reviewed
Feb 21, 2025
andyw8
reviewed
Feb 21, 2025
|
I tried this on https://github.com/Shopify/lhm and noticed it shows the spec files but not the tests, can you look into why this is? |
alexcrocha
changed the title
vinistock
reviewed
Feb 24, 2025
Morriar
reviewed
Feb 25, 2025
alexcrocha
force-pushed
the
ar/spec-test
branch
from
aacd858 to
c51c3a2
Compare
andyw8
reviewed
Feb 25, 2025
vinistock
reviewed
Feb 25, 2025
alexcrocha
force-pushed
the
ar/spec-test
branch
from
c51c3a2 to
e340715
Compare
vinistock
reviewed
Feb 26, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
This came up while pairing with @alexcrocha on #3223 Ref: https://rubydoc.info/gems/minitest/4.1.0/MiniTest/Spec#it-class_method
alexcrocha
force-pushed
the
ar/spec-test
branch
from
e340715 to
be15388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses and closes #3178 by adding support for Minitest spec style syntax. Previously, our support was limited to the traditional test style syntax.
By adding support for the spec style, we enhance the discoverability of tests in VS Code's Test Explorer panel, improving the developer experience.
Implementation
describeanditmethodsdef test_)Tests