Include tags in TestItem#to_hash #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
andyw8
approved these changes
Feb 25, 2025
vinistock
force-pushed
the
02-25-include_tags_in_testitem_to_hash
branch
from
62a6bd6 to
b73d863
Compare
### Motivation I forgot to include the new `tags` field in the `to_hash` response, which means we never return it to the extension. ### Implementation Added `tags` to `to_hash`. ### Automated Tests Updated tests.
graphite-app
bot
force-pushed
the
02-25-include_tags_in_testitem_to_hash
branch
from
b73d863 to
0b635cd
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I forgot to include the new
tagsfield in theto_hashresponse, which means we never return it to the extension.Implementation
Added
tagstoto_hash.Automated Tests
Updated tests.