Update syntax tree requirement to 3.6.3 #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Oct 12, 2022
Morriar
approved these changes
Oct 12, 2022
vinistock
pushed a commit
that referenced
this pull request
Feb 28, 2024
…pt-eslint/parser-5.47.0 Bump @typescript-eslint/parser from 5.46.1 to 5.47.0
klaaspieter
pushed a commit
to klaaspieter/ruby-lsp
that referenced
this pull request
Feb 25, 2025
Don't push group id to stack when encountering non-test classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The newly released v3.6.3 of syntax tree includes a bug fix for a long standing issue of
no implicit conversion of nil to integerwhen editing files.In our metrics, this is our top exception, so we should enforce that folks are using the latest syntax tree and are not hitting this bug.
Implementation
Just updated the requirement to 3.6.3 and re-generated the RBI.