Bring back extend T::Generic for add-on API classes
#3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
st0012
approved these changes
May 13, 2025
vinistock
deleted the
05-12-bring_back_extend_t_generic_for_add-on_api_classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We can't remove the
extend T::Genericstatements from classes that are involved in the public add-on API without marking it as a breaking change. If the add-on is using Sorbet and puts an inline signature in the code referencing a generic class, it will crash because theself.[]method no longer exists.This is unfortunately happening in v0.23.18 for the Rails (for users who haven't upgraded) and RSpec add-ons. I think we should bring back the
extend T::Genericand ship a new version to avoid the crashes.Then we mark the removal of these as a breaking changes, so that upgrades happen smoothly.