Fix infinite recursion in constant alias resolution

[pkondzior]

Motivation

Closes #3782

Fixes a SystemStackError that occurred when resolving certain constant aliases. When a nested module defines a constant alias referencing another constant of the same short name in an outer namespace (for example, B = B::C inside A::D), the Ruby LSP indexer entered infinite recursion because seen_names was not propagated to follow_aliased_namespace.

Implementation

Pass seen_names from direct_or_aliased_constant into follow_aliased_namespace to enable proper cycle detection.

Automated Tests

Added a regression test test_resolving_self_referential_constant_alias covering the B = B::C case.

Manual Tests

1. Open VS Code with Ruby LSP enabled.
2. Create a file test.rb:

module A
 module B
   class C
   end
 end
end

module A
 module D
   B = B::C
 end
end

3. Trigger Go to Definition or hover over B inside A::D.
   4.Expected: No crash. B correctly resolves to A::B::C.

[graphite-app]

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[vinistock]

Thanks for the PR! And good catch

[vinistock]

Thank you for the PR!