Fix stack StackLevelError during self referential constant resolution

[pkondzior]

Motivation

Closes #3798

Following code snipper is going to cause StackLevelError and will kill RubyLSP process

Implementation

ruby-lsp is trying to create ConstantAlias from UnresolvedConstantAlias during constant resolution, I am checking if the target matches entry in cases when unresolved entry is same as target entry we should bail out from resolution because thats the same unresolved entry.

Automated Tests

I've created RubyIndexer::ConstantTest#test_self_referential_constant_alias that is giving coverage for this case

Manual Tests

1. Bootstrap VS Code ruby-lsp from this branch
2. Paste following code into editor

module RealClass
  CONSTANT = {}
end

module Foo
  SomeClass = ::SomeClass
  RealClass = ::RealClass

  UNRESOLVED = SomeClass::CONSTANT
  CONSTANT = RealClass::CONSTANT
end


RealClass
Foo::UNRESOLVED

3. Working on the file should not cause any errors on Ruby LSP in the output

[graphite-app]

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[vinistock]

Thank you for the PR! I believe the fix is the right way to go, but let's make sure the test prevents us from regressing on this