Escape file paths for test command resolution #3802
Merged
+175
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
st0012
approved these changes
Oct 28, 2025
Merge activity
|
### Motivation We weren't escaping file paths for test execution every time, which means paths including special characters (like parenthesis), failed to execute properly. ### Implementation We need to ensure we always escape paths or else we can't execute some less common, yet valid, file paths. ### Automated Tests Added tests.
graphite-app
bot
force-pushed
the
09-03-escape_file_paths_for_test_resolution
branch
from
a6ef0a3 to
1e87bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We weren't escaping file paths for test execution every time, which means paths including special characters (like parenthesis), failed to execute properly.
Implementation
We need to ensure we always escape paths or else we can't execute some less common, yet valid, file paths.
Automated Tests
Added tests.