Add missing kinds for indexer entries #3803
Merged
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
vinistock
requested review from
alexcrocha,
egiurleo and
st0012
and removed request for
a team
st0012
approved these changes
Oct 28, 2025
Merge activity
|
### Motivation Closes #3781 We were missing some possible entries and returning a `nil` kind can cause trouble for editors. ### Implementation I added a fallback with `NULL` and a test that indexes our own codebase and checks that no kinds are `NULL`. This should help us prevent regressions.
graphite-app
bot
force-pushed
the
10-28-add_missing_kinds_for_indexer_entries
branch
from
d7b0abf to
62dacba
Compare
alexcrocha
approved these changes
Oct 28, 2025
jesse-shopify
approved these changes
Oct 28, 2025
graphite-app
bot
deleted the
10-28-add_missing_kinds_for_indexer_entries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3781
We were missing some possible entries and returning a
nilkind can cause trouble for editors.Implementation
I added a fallback with
NULLand a test that indexes our own codebase and checks that no kinds areNULL. This should help us prevent regressions.