-
Notifications
You must be signed in to change notification settings - Fork 225
Add server extensions documentation #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
st0012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed documentation. I think it provides enough info to help developers get started 👍
Just added a few suggestions.
fb70f86 to
5e893d6
Compare
|
This is good but it's hard to review for ease of understanding since we are already heavily involved in Ruby LSP's development. It would be helpful to get some 'outsider' feedback. |
|
Should we point people to the Ruby DX Slack for help? Maybe start a |
5e893d6 to
6e60ba9
Compare
|
@andyw8 great idea. I created a channel for |
st0012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6e60ba9 to
5770c98
Compare
Closes #588
Add documentation for extension authors. I tried to include our motivations and goals, guidelines to avoid common pitfalls and instructions on how to build an extension.
One thing that's missing is instructions for test helpers, mainly because we didn't build those yet. Is there anything else missing that would be helpful?