Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/ruby_lsp/requests/support/dependency_detector.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,12 @@ def detected_formatter

sig { returns(String) }
def detected_test_library
# A Rails app may have a dependency on minitest, but we would instead want to use the Rails test runner provided
# by ruby-lsp-rails.
if direct_dependency?(/^rails$/)
"rails"
# NOTE: Intentionally ends with $ to avoid mis-matching minitest-reporters, etc. in a Rails app.
if direct_dependency?(/^minitest$/)
elsif direct_dependency?(/^minitest$/)
"minitest"
elsif direct_dependency?(/^test-unit/)
"test-unit"
Expand Down
43 changes: 43 additions & 0 deletions test/requests/support/dependency_detector_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# typed: true
# frozen_string_literal: true

require "test_helper"

module RubyLsp
class DependencyDetectorTest < Minitest::Test
def test_detects_no_test_library_when_there_are_no_dependencies
dependencies = {}
Bundler.locked_gems.stubs(dependencies: dependencies)

assert_equal("unknown", DependencyDetector.detected_test_library)
end

def test_detects_minitest
dependencies = { "minitest" => "1.2.3" }
Bundler.locked_gems.stubs(dependencies: dependencies)

assert_equal("minitest", DependencyDetector.detected_test_library)
end

def test_does_not_detect_minitest_related_gems_as_minitest
dependencies = { "minitest-reporters" => "1.2.3" }
Bundler.locked_gems.stubs(dependencies: dependencies)

assert_equal("unknown", DependencyDetector.detected_test_library)
end

def test_detects_test_unit
dependencies = { "test-unit" => "1.2.3" }
Bundler.locked_gems.stubs(dependencies: dependencies)

assert_equal("test-unit", DependencyDetector.detected_test_library)
end

def test_detects_rails_if_both_rails_and_minitest_are_present
dependencies = { "minitest" => "1.2.3", "rails" => "1.2.3" }
Bundler.locked_gems.stubs(dependencies: dependencies)

assert_equal("rails", DependencyDetector.detected_test_library)
end
end
end