Fix code lens disappear after non-test class issue #778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we always pop a class from the stack when we run
after_class, but only push test classes when we runon_class. This means that if we encounter a non-test class in the middle of a test class, we will mistakenly pop the test class from the stack.Implementation
This commit fixes this by pushing a non-test class to the stack too. But while doing so, we also need to check if
on_defis in a test class or not.Automated Tests
Added a new case for it.
Manual Tests
Currently, the
test_after_request_hookinHoverExpectationsTestdoesn't have code lens due to the issue I described. It should appear when switched to this branch.