Skip to content

Improve input validation with visitor #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 23, 2025
Merged

Improve input validation with visitor #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7b1b888
initial implementation of visitor
adampetro Oct 16, 2025
cc00089
additional features
lopert Oct 16, 2025
e8c7c07
additional test fixtures
lopert Oct 16, 2025
aa1c81f
clean up new files
lopert Oct 17, 2025
db089f7
remove old files, rename new files in their place
lopert Oct 17, 2025
cffbef2
remove package-lock, prefer pnpm-lock
lopert Oct 20, 2025
f41808e
move workspaces to pnpm-workspace
lopert Oct 20, 2025
ad9e138
comment for isInputType + coerceInputValue on output types.
lopert Oct 21, 2025
23870f0
flattenNestedArrays
lopert Oct 21, 2025
32130d5
missing js-docs
lopert Oct 21, 2025
b74a466
inline data for tests for validateFixtureInput
lopert Oct 21, 2025
a082a13
clean up test fixtures
lopert Oct 21, 2025
599cdb3
use it.skip for unsupported test cases
lopert Oct 21, 2025
4c59095
remove `valid` on validation return types. Rely on errors.length inst…
lopert Oct 21, 2025
bd634ec
improve comment for flattenNestedArrays
lopert Oct 21, 2025
5fcba95
remove redundant continues
lopert Oct 21, 2025
fa7ec99
use pnpm workspaces for test-app/extensions deps
lopert Oct 21, 2025
27c25af
rework nestedArray traversing to handle nulls.
lopert Oct 22, 2025
8dc30f0
clean up test
lopert Oct 22, 2025
328720a
use toHaveLength
lopert Oct 23, 2025
32b548a
better type for processNestedArrays arg value
lopert Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
public-hoist-pattern[]=*@graphql-codegen/*
public-hoist-pattern[]=graphql-code-generator
9 changes: 9 additions & 0 deletions dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: shopify-function-test-helpers

type:
- node

up:
- node:
version: 24.1.0
package_manager: pnpm@10.11.1
Loading