client.Populate assign client to proxy#291
Merged
miry merged 4 commits intoShopify:masterfrom Nov 2, 2021
Merged
Conversation
Contributor
|
@hellodudu can you add tests to cover the panic? |
Contributor
Author
|
Hi @miry, It's done. |
Contributor
|
@hellodudu Thank you very much. Last steps:
|
Contributor
Author
|
Contributor
|
@hellodudu It looks like: In the end it would ask to provide description. https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits |
Contributor
|
@hellodudu If you want I can squash and try to combine your messages in one? |
Contributor
Author
|
Yes please. I'm afraid of messing it up. Thanks a lot! |
Contributor
|
@hellodudu thank you again for contribution ❤️ . Going to update my samples of toxiproxy usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.Populateshould assign client to proxies first, otherwise it will panic if we callproxy.AddToxic()