Merged
Conversation
neufeldtech
commented
Mar 4, 2022
djlebersilvestre
approved these changes
Mar 4, 2022
Contributor
Author
|
Note: When testing these instructions, I came across a problem with the proposed workflow of creating a pull request for updating the release notes and preparing the release... When I did this, because github forced me to do a squash and merge, then there was a mismatch between the commit that landed on master and the tag that I had previously created locally. Options for this workflow are:
@miry when you're back from vacation, let's chat on this some more |
miry
reviewed
Mar 8, 2022
miry
reviewed
Mar 8, 2022
miry
reviewed
Mar 8, 2022
miry
reviewed
Mar 8, 2022
miry
reviewed
Mar 8, 2022
Contributor
|
@neufeldtech Thank you for the doc ❤️ |
neufeldtech
commented
Mar 8, 2022
neufeldtech
commented
Mar 8, 2022
neufeldtech
commented
Mar 8, 2022
miry
reviewed
Mar 10, 2022
miry
approved these changes
Mar 10, 2022
Contributor
Author
|
Hmmm, I might have a flaky test.... === RUN TestProxyMetricsReceivedSentBytes
metrics_test.go:36: expected: [toxiproxy_proxy_received_bytes_total{direction="upstream",listener="localhost:0",proxy="test",upstream="upstream"} 5 toxiproxy_proxy_sent_bytes_total{direction="upstream",listener="localhost:0",proxy="test",upstream="upstream"} 5] got: []This test was added in my prometheus metrics PR #366 |
Co-authored-by: Michael Nikitochkin <michael.nikitochkin@shopify.com>
attempt to address race condition in tests that happens in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #368