- 
                Notifications
    
You must be signed in to change notification settings  - Fork 95
 
ReactESP v2 changes #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    ReactESP v2 changes #475
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            15 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      3be3eb4
              
                Fix the release process documentation and helper
              
              
                mairas 96ab2fe
              
                Peg ReactESP to ^2.0.0
              
              
                mairas 12d0e58
              
                Pull the reactesp namespace into sensesp
              
              
                mairas a03699a
              
                Update the analog_input example
              
              
                mairas 1ea138f
              
                Update the chain counter example
              
              
                mairas 956e004
              
                Update the hysteresis example
              
              
                mairas 38a35cd
              
                Update the lambda transform example
              
              
                mairas 1a7aeb8
              
                Update the minimal_app example
              
              
                mairas c2e6f42
              
                Update the relay_control example
              
              
                mairas 22cf21e
              
                Update the rpm_counter example
              
              
                mairas f9ada89
              
                Update the temperature_sender example
              
              
                mairas c5cc4ad
              
                Update the fuel_level_sensor example
              
              
                mairas 4760cd9
              
                Update the milone_level_sensor example
              
              
                mairas c37fb16
              
                Update the remote_switch example
              
              
                mairas 318a7b7
              
                Update the smart switch example
              
              
                mairas File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you eliminate the specific types of SKOutput, by making it a template type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a template type, but for convenience, those specific types are still defined at the end of
signalk_output.h:If it was just up to me, I would indeed have a mild preference for ditching those typedefs and just using the template syntax, but I've accepted the notion that there are SensESP users who're not comfortable with the C++ template class syntax and it's better to have the typedefs around. :-)