Fix support for COMMAND_CLASS_METER V1,V2 & V3 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Example devics are Aeotec Nano Dimmer (ZW111) and Fibaro Double Switch 2 (FGS 223). |
rzr
reviewed
Aug 21, 2023
applications/zpc/components/zwave_command_classes/src/zwave_command_class_meter_control.c
Show resolved
Hide resolved
rzr
reviewed
Aug 21, 2023
applications/zpc/components/zwave_command_classes/src/zwave_command_class_meter_control.c
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Added DCO signed-off in commit message |
Signed-off-by: Nenad Kljajic <43343836+nkljajic@users.noreply.github.com>
Collaborator
|
Feel free to reopen this PR once you have approvals both side (not under my controls) Meanwhile I have briefed unity team to help you, while I am OoO, we plan to test your patches and provide feedback here and then merge them at the right time both side, (idealy before next release) Feel free to ask support |
Collaborator
|
May this PR be reopened ? |
Collaborator
Author
|
I will create new patch for 1.4.0 release. Support Case |
1 task
Collaborator
excellent, if you want to track your changes you can add this case number in your commits footer |
rzr
added a commit
that referenced
this pull request
Mar 28, 2025
This change is motivated by zeal project Tests are passing, but it fail later on installing package: #12 1.646 dpkg: error processing archive ./build/z-wave-protocol-controller_1.7.0_x86_64/libunify_1.7.0-65-gbc86741e_x86_64.deb (--install): Error: No space left on device : '/home/runner/runners/2.323.0/_diag/pages/a643bedf-49e7-4c3e-9568-b498945dda79_dd23db01-cff6-57a4-373a-5c8097a97333_1.log' I suspect the cause it all the assets in tree, this has to be cleaned up. This change prevent this problem, further cleaning may be considered. Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 (comment) Relate-to: SiliconLabsSoftware/z-wave-protocol-controller#77 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#7 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Thomasdjb
pushed a commit
to Thomasdjb/UnifySDK
that referenced
this pull request
May 22, 2025
This change is motivated by zeal project Tests are passing, but it fail later on installing package: SiliconLabs#12 1.646 dpkg: error processing archive ./build/z-wave-protocol-controller_1.7.0_x86_64/libunify_1.7.0-65-gbc86741e_x86_64.deb (--install): Error: No space left on device : '/home/runner/runners/2.323.0/_diag/pages/a643bedf-49e7-4c3e-9568-b498945dda79_dd23db01-cff6-57a4-373a-5c8097a97333_1.log' I suspect the cause it all the assets in tree, this has to be cleaned up. This change prevent this problem, further cleaning may be considered. Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 (comment) Relate-to: SiliconLabsSoftware/z-wave-protocol-controller#77 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#10 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#11 Relate-to: SiliconLabsSoftware/z-wave-engine-application-layer#7 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size of ZW_METER_GET_V3_FRAME is smaller than size of ZW_METER_GET_V5_FRAME, so legacy device with COMMAND_CLASS_METER_V3 and below will receive V5 frame which is larger than expected, and device will ignore such frames, so attribute [0x3208] Value can not get resolved for legacy devices.