Unit tests, Maros Meszaros: Redefine function load_qp #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabinsch
approved these changes
Nov 24, 2025
…h intern skipping of large problems, to avoid useless computations (adapt from Eigen 3 to Eigen5)
jorisv
force-pushed
the
fix/test_maros_meszaros_eigen5
branch
from
7618e70 to
f7185f8
Compare
jorisv
approved these changes
Nov 24, 2025
Contributor
There was a problem hiding this comment.
We look with @Lucas-Haubert why load_qp is way slower with Eigen5. It turn out the SparseMatrix::insert method is taking all the time.
Since this method is only use to create maros_meszaros problem or random qp problem we will not investigate the issue right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solved the execution time of the Maros Meszaros unit tests with Eigen5.
In the files, all the problems are called in
files[], then loaded in theload_qpfunction. Then, depending on the problem size, the instance can be skipped, or not.With Eigen3: The
load_qpfunction is fast.With Eigen5: Its execution time seems proportional to the problems size, due to an internal loop.
The proposed correction:
Note:
ProxQP::dense: test primal infeasibility solvingtest. Indeed, this test is run with Eigen5. A fix for this test is proposed in PR Correction of update status PROXQP_SOLVED_CLOSEST_FEASIBLE in dense backend #432.