Skip to content

Conversation

@ajaust
Copy link
Member

@ajaust ajaust commented Nov 16, 2021

WIP

@ajaust ajaust force-pushed the add-overview-systempaths-librarytools branch from 7aade15 to 2f71396 Compare November 21, 2021 10:46
@ajaust ajaust self-assigned this Nov 22, 2021
@ajaust ajaust marked this pull request as ready for review November 22, 2021 11:04
@ajaust ajaust requested a review from uekerman November 22, 2021 11:04
@ajaust
Copy link
Member Author

ajaust commented Nov 22, 2021

@uekerman You can check now if the content makes sense to you and if there is anything you are missing for your part of the lecture or conflicting with #51.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like 👍
I think this content is very important and will be highly appreciated by students.

I guess with ldconfig and pkg-condig, you will need more than 30 mins. Both are not needed for cmake, but could go into the spack/deb week?
That would also have the side effect that they then already know how to read makefiles and better understand your PETSc example.
You could also just see where you are after 30 mins and cut adaptively.

I am bit confused by the systempaths-and-librarytools_text.md file.
Most of this you have ported to the slides and could go away, right?
And the rest would go to building-and-packaging/overview.md?

@ajaust ajaust force-pushed the add-overview-systempaths-librarytools branch from ea7df9a to 028aa75 Compare November 23, 2021 10:58
@ajaust
Copy link
Member Author

ajaust commented Nov 23, 2021

I am bit confused by the systempaths-and-librarytools_text.md file. Most of this you have ported to the slides and could go away, right? And the rest would go to building-and-packaging/overview.md?

Yes, I started to put content in notes which became systempaths-and-librarytools_text.md and I made the slides based on this. I was not sure whether I want/can touch the overview.md at the moment because I did not find much content from the Python lecture there. I also unsure whether the overview.md might get too full at some point.

@uekerman
Copy link
Member

I was not sure whether I want/can touch the overview.md at the moment because I did not find much content from the Python lecture there. I also unsure whether the overview.md might get too full at some point.

I would say let's stick to this pattern this semester. And refactor afterwards. Notes, you can always move to _text.md files if necessary.

@ajaust ajaust force-pushed the add-overview-systempaths-librarytools branch from b6a4415 to 4eade88 Compare November 24, 2021 09:24
@ajaust
Copy link
Member Author

ajaust commented Nov 24, 2021

I was not sure whether I want/can touch the overview.md at the moment because I did not find much content from the Python lecture there. I also unsure whether the overview.md might get too full at some point.

I would say let's stick to this pattern this semester. And refactor afterwards. Notes, you can always move to _text.md files if necessary.

I moved things now into the overview.md.

@ajaust ajaust force-pushed the add-overview-systempaths-librarytools branch from d25e27c to 46e6b3e Compare November 24, 2021 13:32
@ajaust ajaust merged commit 1443e0d into main Nov 24, 2021
@ajaust ajaust deleted the add-overview-systempaths-librarytools branch November 24, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants