Skip to content

refactor: Improve sanitizeObject function to handle additional quote types and whitespace characters #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

refactor: Improve sanitizeObject function to handle additional quote types and whitespace characters #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions netlify/functions/batchUpdateMeetingSummariesArray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,21 @@ const MAX_CONCURRENT_REQUESTS = 10;

function sanitizeObject(item) {
if (typeof item === 'string') {
// 1. Remove line breaks
// 2. Replace fancy dashes with '-'
// 3. Replace curly single quotes ’ and ‘ with straight apostrophe '
// 4. Replace curly double quotes ” and “ with straight ASCII quote "
// 5. Escape any new " characters to \" for valid JSON

return item
.replace(/\r?\n/g, ' ')
.replace(/[\u2013\u2014]/g, '-')
.replace(/[\u2018\u2019]/g, "'")
.replace(/[\u201C\u201D]/g, '"')
.replace(/"/g, '\\"')
.replace(/\r?\n/g, ' ') // Remove newlines
.replace(/[\u2013\u2014\u2015]/g, '-') // Handle en dash, em dash, and horizontal bar
.replace(/[\u2018\u2019\u201A\u201B\u2032\u2035]/g, "'") // Handle various single quotes
.replace(/[\u201C\u201D\u201E\u201F\u2033\u2036]/g, '"') // Handle various double quotes
.replace(/[\u2026]/g, '...') // Handle ellipsis
.replace(/[\u00A0]/g, ' ') // Replace non-breaking space with regular space
.trim();
}

if (Array.isArray(item)) {
return item.map(element => sanitizeObject(element));
}

if (item && typeof item === 'object') {
const newObj = {};
for (const key in item) {
Expand All @@ -33,7 +30,7 @@ function sanitizeObject(item) {
return newObj;
}

// For numbers, booleans, null, etc., return as is
// for numbers, booleans, null, etc just return item.
return item;
}

Expand Down
20 changes: 8 additions & 12 deletions netlify/functions/batchUpdateMeetingSummariesById.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,16 @@ const MAX_CONCURRENT_REQUESTS = 10;

function sanitizeObject(item) {
if (typeof item === 'string') {
// 1. Remove line breaks
// 2. Replace fancy dashes with '-'
// 3. Replace curly single quotes ’ and ‘ with straight apostrophe '
// 4. Replace curly double quotes ” and “ with straight ASCII quote "
// 5. Escape any new " characters to \" for valid JSON

return item
.replace(/\r?\n/g, ' ')
.replace(/[\u2013\u2014]/g, '-')
.replace(/[\u2018\u2019]/g, "'")
.replace(/[\u201C\u201D]/g, '"')
.replace(/"/g, '\\"')
.replace(/\r?\n/g, ' ') // Remove newlines
.replace(/[\u2013\u2014\u2015]/g, '-') // Handle en dash, em dash, and horizontal bar
.replace(/[\u2018\u2019\u201A\u201B\u2032\u2035]/g, "'") // Handle various single quotes
.replace(/[\u201C\u201D\u201E\u201F\u2033\u2036]/g, '"') // Handle various double quotes
.replace(/[\u2026]/g, '...') // Handle ellipsis
.replace(/[\u00A0]/g, ' ') // Replace non-breaking space with regular space
.trim();
}
}

if (Array.isArray(item)) {
return item.map(element => sanitizeObject(element));
Expand All @@ -37,7 +34,6 @@ function sanitizeObject(item) {
return item;
}


async function fetchMeetingSummaries(lastProcessedTimestamp, batchNumber) {
const { data: summaries, error } = await supabase
.from('meetingsummaries')
Expand Down