Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

See clairernovotny/DeterministicBuilds#4 (comment)

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1560 (33b118c) into master (138c75b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1560   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files         742      742           
  Lines       32877    32877           
  Branches     3674     3674           
=======================================
  Hits        27483    27483           
  Misses       4680     4680           
  Partials      714      714           
Flag Coverage Δ
unittests 83.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138c75b...33b118c. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit aca46ac into master Feb 18, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/deteministic-build-fix branch February 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants