-
-
Notifications
You must be signed in to change notification settings - Fork 887
Add support for decoding tiff's with float pixel data #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
+ Coverage 84.38% 84.43% +0.04%
==========================================
Files 830 833 +3
Lines 36288 36390 +102
Branches 4241 4257 +16
==========================================
+ Hits 30621 30725 +104
+ Misses 4850 4845 -5
- Partials 817 820 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| for (int x = 0; x < pixelRow.Length; x++) | ||
| { | ||
| data.Slice(offset, 4).CopyTo(buffer); | ||
| Array.Reverse(buffer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use BinaryPrimitives.ReadSingleBigEndian here and elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadSingleBigEndian is only available with net5.0 and above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know that. Looking at the source we could only polyfill back to .NET Core 2.0 also. We'll leave it like this for now.
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👍
Prerequisites
Description
This PR adds support for decoding Tiff images with float pixel data.