Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR adds support for decoding tiff's with horizontal predictor for 16/32 bit gray tiff's and 16/32 bit color tiff's.

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #1729 (05a4c5e) into master (a6c708f) will increase coverage by 0.07%.
The diff coverage is 99.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
+ Coverage   84.43%   84.50%   +0.07%     
==========================================
  Files         833      833              
  Lines       36390    36565     +175     
  Branches     4257     4276      +19     
==========================================
+ Hits        30725    30899     +174     
  Misses       4845     4845              
- Partials      820      821       +1     
Flag Coverage Δ
unittests 84.50% <99.45%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rp/Formats/Tiff/Compression/HorizontalPredictor.cs 99.54% <99.41%> (-0.46%) ⬇️
...ompression/Decompressors/DeflateTiffCompression.cs 96.00% <100.00%> (+0.34%) ⬆️
...ff/Compression/Decompressors/LzwTiffCompression.cs 100.00% <100.00%> (ø)
...rmats/Tiff/Compression/TiffDecompressorsFactory.cs 71.42% <100.00%> (ø)
src/ImageSharp/Formats/Tiff/TiffDecoderCore.cs 89.92% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c708f...05a4c5e. Read the comment docs.

# Conflicts:
#	src/ImageSharp/Formats/Tiff/Compression/TiffDecompressorsFactory.cs
#	src/ImageSharp/Formats/Tiff/TiffDecoderCore.cs
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

# Conflicts:
#	tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs
#	tests/ImageSharp.Tests/TestImages.cs
@brianpopow brianpopow merged commit 74283c7 into master Aug 11, 2021
@brianpopow brianpopow deleted the bp/predictor branch August 11, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants