Jpeg codebase cleanup #1853
Jpeg codebase cleanup #1853
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1853 +/- ##
=======================================
- Coverage 87% 87% -1%
=======================================
Files 937 935 -2
Lines 48868 48751 -117
Branches 6097 6081 -16
=======================================
- Hits 42750 42586 -164
- Misses 5111 5154 +43
- Partials 1007 1011 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
src/ImageSharp/Formats/Jpeg/Components/Encoder/LuminanceForwardConverter{TPixel}.cs
Outdated
Show resolved
Hide resolved
| @@ -1,23 +0,0 @@ | |||
| // Copyright (c) Six Labors. | |||
There was a problem hiding this comment.
GenericBlock8x8.Generated.tt is an empty file -- should it be deleted?
There was a problem hiding this comment.
It should, looks like I forgot about it, thanks!
There was a problem hiding this comment.
This might be a github diff bug or something but I couldn't find GenericBlock8x8.Generated.tt file in my repo:
There was a problem hiding this comment.
Should be under Format\Jpeg\Components
There was a problem hiding this comment.
Yeah but screen above is Format\Jpeg\Components, here's another one directly from VS:
Sorry for my agnorance but what those .Generated.tt files mean exactly? First time encountering those.
There was a problem hiding this comment.
They're T4 templates generating partials of the named types. If you expand them you see the generated file. e.g. Block8x8F.Generated.cs.
That empty one looks like a leftover from previous cleanup and is safe to delete.
There was a problem hiding this comment.
Completely missed your response - thanks for clarifying .tt stuff! GenericBlock8x8.Generated.tt seems to be deleted now (I did nothing after this review, looks like a diff tool bug or whatever).
…benchmark project
…ved test benchmark call from sandbox project
br3aker
force-pushed
the
dp/jpeg-decoder-cleanup
branch
from
57db167 to
717b166
Compare
|
Current progress is big enough for review, there's still some work left - I will work on it as a separate PR. |
|
Wow that was fast, thanks! |
|
I've been struggling to find something useful to do so have been focusing on keeping up with PRs. |
3 participants
Prerequisites
Description
Right now this PR exist purely to test crashes during testing, work is still in progress.
This PR consists of a lot of small fixes to the jpeg codebase: general cleanup, redundant/unused code removal and small performance tweaks via removing unnecessary checks.