-
-
Notifications
You must be signed in to change notification settings - Fork 888
Use Rgb24 for Async Jpeg Decode #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
======================================
Coverage 87% 87%
======================================
Files 935 935
Lines 48751 48751
Branches 6081 6081
======================================
+ Hits 42585 42590 +5
+ Misses 5155 5153 -2
+ Partials 1011 1008 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! If you have a bit of more time an equivalent async test might be useful:
ImageSharp/tests/ImageSharp.Tests/Formats/Jpg/JpegDecoderTests.cs
Lines 88 to 94 in d81c511
[Fact] | |
public void Decode_NonGeneric_CreatesRgb24Image() | |
{ | |
string file = Path.Combine(TestEnvironment.InputImagesDirectoryFullPath, TestImages.Jpeg.Baseline.Jpeg420Small); | |
using var image = Image.Load(file); | |
Assert.IsType<Image<Rgb24>>(image); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Prerequisites
Description
Non-generic async jpeg decoding was still using
Rgba32
by default.