Add SSE2 and AVX2 versions of Vp8_Sse16X16 and Vp8_Sse16X8 #1881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1881 +/- ##
======================================
Coverage 87% 87%
======================================
Files 959 959
Lines 50402 50462 +60
Branches 6260 6266 +6
======================================
+ Hits 44118 44182 +64
+ Misses 5248 5246 -2
+ Partials 1036 1034 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gfoidl
reviewed
Dec 9, 2021
Comment on lines
190
to
191
| ref byte aRef = ref MemoryMarshal.GetReference(a); | ||
| ref byte bRef = ref MemoryMarshal.GetReference(b); |
There was a problem hiding this comment.
These should be moved above the loop -- they're invariant to the loop.
Comment on lines
215
to
216
| ref byte aRef = ref MemoryMarshal.GetReference(a); | ||
| ref byte bRef = ref MemoryMarshal.GetReference(b); |
Co-authored-by: Günther Foidl <gue@korporal.at>
JimBobSquarePants
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds SSE2 and AVX2 versions of
Vp8_Sse16X16andVp8_Sse16X8, which are used during lossy webp encoding.Related to #1786
Profiling results:
master
PR