-
Notifications
You must be signed in to change notification settings - Fork 28
Kubernetes example #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes example #914
Conversation
c551270 to
df3af00
Compare
60be99c to
8d57055
Compare
|
Marked as ready for review: the app can now scale up/down to X skip instances with just a Will write up a detailed blog post/tutorial but following the steps I added to the |
No longer necessary now that Skip pods directly communicate their IP address to HAProxy.
8d57055 to
161213e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is precision work 👌
One little change in the name of the container, a couple of suggestion for our local tooling (adding explicitly bash to the code section in markdown). Up to you :)
Putting this up for review now; should work as is if you follow instructions I added to
./examples/hackernews/README.md.There's still some manual configuration changes required to scale out the followers of the Skip service: creating a corresponding
skip-ingress-Xservice fronting each pod of the statefulset, and adding the routing logic to the reverse proxy.The
skip-ingress-Xservices can easily be scripted, but using the current setup changing that routing logic requires a HAProxy restart. I'm working on a more dynamic config for haproxy using maps, but that's still a WIP.