fix: Fixed various remaining bugs.

Author: Skyost

lib/model/storage/online.dart

@@ -95,7 +95,7 @@ class OnlineStorage with Storage {
   @override
   Future<void> updateTotp(String uuid, Totp totp) async {
     CollectionReference? collection = _totpsCollection;
-    await collection.doc(uuid).update(totp.toFirestore());
+    await collection.doc(uuid).set(totp.toFirestore());
   }
 
   @override

lib/model/totp/decrypted.dart

@@ -53,6 +53,9 @@ class DecryptedTotp extends Totp {
         period: validity ?? Totp.kDefaultValidity,
       );
 
+  /// Generates a code using the [generator].
+  String generateCode() => generator.value().toString().padLeft(digits ?? Totp.kDefaultDigits, '0');
+
   @override
   List<Object?> get props => [...super.props, secret, label, issuer];
 

lib/utils/utils.dart

@@ -28,7 +28,7 @@ String generateRandomString([int length = 20]) {
   return String.fromCharCodes(Iterable.generate(length, (_) => chars.codeUnitAt(random.nextInt(chars.length))));
 }
 
-/// Compares two [Uint8List]s by comparing 8 bytes at a time.ù
+/// Compares two [Uint8List]s by comparing 8 bytes at a time.
 /// Kudos to https://stackoverflow.com/a/70751501/3608831.
 bool memEquals(Uint8List bytes1, Uint8List bytes2) {
   if (identical(bytes1, bytes2)) {

lib/widgets/totp/code.dart

@@ -41,7 +41,7 @@ class _TotpCodeWidgetState extends TimeBasedTotpWidgetState<TotpCodeWidget> {
     if (!widget.totp.isDecrypted) {
       return '';
     }
-    String code = (widget.totp as DecryptedTotp).generator.value().toString();
+    String code = (widget.totp as DecryptedTotp).generateCode();
     StringBuffer buffer = StringBuffer();
     for (int i = 0; i < code.length; i++) {
       buffer.write(code[i]);

lib/widgets/totp/image.dart

@@ -167,16 +167,7 @@ class _TotpCountdownImageWidgetState extends TimeBasedTotpWidgetState<TotpCountd
     if (((DateTime.now().millisecondsSinceEpoch ~/ 1000) ~/ this.validity).isEven) {
       changeColors();
     }
-    Duration validity = _validity;
-    animationController = AnimationController(
-      vsync: this,
-      duration: validity,
-      upperBound: this.validity.toDouble(),
-    )
-      ..addListener(() {
-        setState(() {});
-      })
-      ..forward(from: (validity - calculateExpirationDuration()).inMilliseconds / 1000);
+    scheduleAnimation();
   }
 
   @override
@@ -200,25 +191,53 @@ class _TotpCountdownImageWidgetState extends TimeBasedTotpWidgetState<TotpCountd
         ),
       );
 
+  @override
+  void didUpdateWidget(covariant TotpCountdownImageWidget oldWidget) {
+    super.didUpdateWidget(oldWidget);
+    if (oldWidget.totp.validity != widget.totp.validity) {
+      cancelAnimation();
+      scheduleAnimation();
+    }
+  }
+
   @override
   void dispose() {
-    animationController.dispose();
+    cancelAnimation();
     super.dispose();
   }
 
   @override
   void updateState({bool changeColors = true}) {
     if (mounted) {
+      animationController.duration = _validity;
+      animationController.forward(from: 0);
       setState(() {
-        animationController.duration = _validity;
-        animationController.forward(from: 0);
         if (changeColors) {
           this.changeColors();
         }
       });
     }
   }
 
+  /// Schedule the animation.
+  void scheduleAnimation() {
+    Duration validity = _validity;
+    animationController = AnimationController(
+      vsync: this,
+      duration: validity,
+      upperBound: this.validity.toDouble(),
+    )
+      ..addListener(() {
+        setState(() {});
+      })
+      ..forward(from: (validity - calculateExpirationDuration()).inMilliseconds / 1000);
+  }
+
+  /// Cancels the animation.
+  void cancelAnimation() {
+    animationController.dispose();
+  }
+
   /// Changes the colors.
   void changeColors() {
     Color? temporary = color;

lib/widgets/totp/time_based.dart

@@ -26,10 +26,16 @@ abstract class TimeBasedTotpWidgetState<T extends TimeBasedTotpWidget> extends S
   @override
   void initState() {
     super.initState();
-    _updateTimer = Timer(calculateExpirationDuration(), () {
-      updateState();
-      _updateTimer = Timer.periodic(Duration(seconds: validity), (_) => updateState());
-    });
+    _scheduleUpdates();
+  }
+
+  @override
+  void didUpdateWidget(covariant T oldWidget) {
+    super.didUpdateWidget(oldWidget);
+    if (oldWidget.totp.validity != widget.totp.validity) {
+      _cancelUpdates();
+      _scheduleUpdates();
+    }
   }
 
   @override
@@ -44,6 +50,14 @@ abstract class TimeBasedTotpWidgetState<T extends TimeBasedTotpWidget> extends S
   /// Triggered when the state should be updated.
   void updateState();
 
+  /// Schedule the updates.
+  void _scheduleUpdates() {
+    _updateTimer = Timer(calculateExpirationDuration(), () {
+      updateState();
+      _updateTimer = Timer.periodic(Duration(seconds: validity), (_) => updateState());
+    });
+  }
+
   /// Cancels the updates.
   void _cancelUpdates() {
     _updateTimer?.cancel();

lib/widgets/totp/widget.dart

@@ -1,7 +1,6 @@
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:open_authenticator/i18n/translations.g.dart';
 import 'package:open_authenticator/model/totp/decrypted.dart';
 import 'package:open_authenticator/model/totp/totp.dart';
@@ -12,7 +11,7 @@ import 'package:open_authenticator/widgets/totp/code.dart';
 import 'package:open_authenticator/widgets/totp/image.dart';
 
 /// Allows to display TOTPs in a [ListView].
-class TotpWidget extends ConsumerWidget {
+class TotpWidget extends StatelessWidget {
   /// The TOTP instance.
   final Totp totp;
 
@@ -51,7 +50,7 @@ class TotpWidget extends ConsumerWidget {
   });
 
   @override
-  Widget build(BuildContext context, WidgetRef ref) {
+  Widget build(BuildContext context) {
     Widget result = Padding(
       padding: contentPadding,
       child: Row(
@@ -126,22 +125,22 @@ class TotpWidget extends ConsumerWidget {
     );
     return (currentPlatform.isMobile || kDebugMode)
         ? InkWell(
-            onLongPress: () => _showMobileActionsMenu(context, ref),
+            onLongPress: () => _showMobileActionsMenu(context),
             child: result,
           )
         : result;
   }
 
   /// Allows to copy the code to the clipboard.
   Future<void> _copyCode(BuildContext context) async {
-    await Clipboard.setData(ClipboardData(text: (totp as DecryptedTotp).generator.value().toString()));
+    await Clipboard.setData(ClipboardData(text: (totp as DecryptedTotp).generateCode()));
     if (context.mounted) {
       SnackBarIcon.showSuccessSnackBar(context, text: translations.totp.actions.copyConfirmation);
     }
   }
 
   /// Triggered when the user long presses the widget on mobile.
-  Future<void> _showMobileActionsMenu(BuildContext context, WidgetRef ref) async {
+  Future<void> _showMobileActionsMenu(BuildContext context) async {
     if (!currentPlatform.isMobile && !kDebugMode) {
       Navigator.pushNamed(context, TotpPage.name);
       return;