Replace BpkParagraph and BpkHeading with BpkText in template #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvooo
commented
Jul 28, 2017
tvooo
commented
- Removed BpkParagraph and BpkHeading
- Added BpkText
- Updated other Backpack dependencies
matthewdavidson
suggested changes
Jul 28, 2017
| padding: $bpk-spacing-base 0; | ||
| } | ||
|
|
||
| &__text { |
There was a problem hiding this comment.
. App__text is declared once but used twice (in the react template). Ideally there should be a one to one mapping of a class to a react element. E.g. imagine we wanted to make the heading underlined:
&__text {
margin-bottom: $bpk-spacing-sm;
text-decoration: underline;
}We've just inadvertently added underline to the paragraph. I reckon we should be setting the right example in the template.
Author
|
Is there a way to request a reviewer to update their review? Except maybe: @matthewdavidson do you want to update your review? :D |
matthewdavidson
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.