[BPK-838] Add optimize-css-assets-webpack-plugin

[k0nserv]

For prod and SSR builds include optimize-css-assets-webpack-plugin to
optimize duplication in CSS output.

[matthewdavidson]

Needs a changelog entry too.

LGTM otherwise

[matthewdavidson]

Whats the thinking here? i.e .why would we need to expose those options to userland config? We don't do this for autoprefixer for instance...

[matthewdavidson]

Also if there is a good reason to do that, then it would need documentation.

[k0nserv]

I figured we'd ship it silently to futureproof when someone inevitably finds something they want to tweak which is why I didn't include docs

[matthewdavidson]

I see. I guess the whole premise of create-react-app (and thus backpack-react-scripts) is to hide the configuration away from consumers. If there is something that a consumer / team deems necessary to include then why wouldn't we wanna include that for everyone? Im tempted to remove it.

[k0nserv]

Fair enough. I’ll remove it 👍

[k0nserv]

Matt thoughts on this. My thinking is that this is a significant change in output result so it should be breaking even though no change is required by the user. Erring on the side of caution

[matthewdavidson]

Is it going to break builds? Is it going to break visual layout of apps?

If the answer is no to both of them then I think it's a fix.

[k0nserv]

Nope it shouldn't affect anything, but it's a more aggressive optimizer so it could introduce issues.

[matthewdavidson]

We can do a smoke test on some internal projects to get confidence?

[k0nserv]

@matthewdavidson Have a look again please

[matthewdavidson]

I've verified this on an internal project.

[matthewdavidson]

unnecessary new line