ENH: Uniformize the use of JsonCpp with VTK #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johan-andruejol
force-pushed
the
UniformizeJsonCMake
branch
from
3164e8c to
2b9e8f8
Compare
Member
|
Getting close 👍 ... looks like there is a last issue with CircleCI |
VTK does not use JsonCpp_DIR. In an effort to be consistent across projects, we should only refer to JsonCpp_INCLUDE_DIR and JsonCpp_LIBRARY. This is futhermore reinforce that JsonCPP_DIR does NOT have to be defined for GenerateCLP to work.
johan-andruejol
force-pushed
the
UniformizeJsonCMake
branch
from
2b9e8f8 to
d58e664
Compare
Contributor
Author
|
@jcfr: I updated the code and now CircleCI passes. I'll merge if you don't have any objections. |
Member
|
Nice work. LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTK does not use JsonCpp_DIR. In an effort to be consistent across
projects, we should only refer to JsonCpp_INCLUDE_DIR and JsonCpp_LIBRARY.
This is futhermore reinforce that JsonCPP_DIR does NOT have to be defined
for GenerateCLP to work.
cc: @jcfr