BUG: Fix GenerateCLP_FORWARD_PATHS_[BUILD/INSTALL] variable #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GenerateCLP_FORWARD_PATHS_BUILD and GenerateCLP_FORWARD_PATHS_INSTALL variables are used to generate a C++ macro. In d58e664 a bug was introduced when SlicerExecutionModel is built without JSON support, the macro is generated with an empty line, breaking compilation. This commit fixes the GenerateCLP_FORWARD_PATHS_[BUILD/INSTALL] variables to make sure the C++ macro are always valid.
|
LGTM |
Member
|
Thanks. 👍 Do you know why the CI didn't catch the problem previously ? |
Contributor
Author
|
@jcfr: CircleCI actually caught it, but it didn't report it correctly it look like: https://circleci.com/gh/Slicer/SlicerExecutionModel/63 |
Member
|
Arff. It looks like running See SlicerExecutionModel/test/Docker/test.sh Line 18 in 983d211 and http://slicer.cdash.org/viewBuildError.php?buildid=881252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GenerateCLP_FORWARD_PATHS_BUILD and GenerateCLP_FORWARD_PATHS_INSTALL
variables are used to generate a C++ macro. In d58e664
a bug was introduced when SlicerExecutionModel is built without JSON
support, the macro is generated with an empty line, breaking compilation.
This commit fixes the GenerateCLP_FORWARD_PATHS_[BUILD/INSTALL] variables
to make sure the C++ macro are always valid.
See Issue #81