Skip to content

Conversation

@HunsupJung
Copy link
Collaborator

@HunsupJung HunsupJung commented Apr 2, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Add Nuki's products to new-matter-lock driver

Summary of Completed Tests

https://smartthings.atlassian.net/browse/WWST-9511?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Channel deleted.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Test Results

   66 files    420 suites   0s ⏱️
2 152 tests 2 152 ✅ 0 💤 0 ❌
3 673 runs  3 673 ✅ 0 💤 0 ❌

Results for commit b3256f6.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against b3256f6

@HunsupJung HunsupJung merged commit 6410f7f into main Apr 4, 2025
11 checks passed
@HunsupJung HunsupJung deleted the feature/add-nuki-to-new-matter-lock-driver branch April 4, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants