preventing unnecessary emitting in edge driver #2357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 69 files 449 suites 0s ⏱️ Results for commit d6c703e. ♻️ This comment has been updated with latest results. |
|
zigbee-contact_coverage.xml
zigbee-lock_coverage.xml
zigbee-presence-sensor_coverage.xml
zigbee-thermostat_coverage.xml
zwave-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against d6c703e |
kdbang
reviewed
Aug 25, 2025
| device:emit_event(capabilities.lock.lock.unlocked()) | ||
| if device:get_latest_state("main", capabilities.lock.ID, capabilities.lock.lock.NAME) == nil and device:supports_capability(capabilities.lock) then | ||
| device:emit_event(capabilities.lock.lock.unlocked()) | ||
| end |
There was a problem hiding this comment.
can you add test case not to send initial value when driver is switched?
There was a problem hiding this comment.
Related TCs have been updated~
pInksenberg
force-pushed
the
preventing-unnecessary-event-emitting-in-edge-driver
branch
4 times, most recently
from
f00dae9 to
cf912ca
Compare
pInksenberg
force-pushed
the
preventing-unnecessary-event-emitting-in-edge-driver
branch
2 times, most recently
from
9db44b6 to
253f560
Compare
kdbang
reviewed
Aug 27, 2025
.../SmartThings/zwave-sensor/src/fibaro-door-window-sensor/fibaro-door-window-sensor-2/init.lua
Outdated
Show resolved
Hide resolved
pInksenberg
force-pushed
the
preventing-unnecessary-event-emitting-in-edge-driver
branch
4 times, most recently
from
48ff16b to
e17e0ea
Compare
kdbang
reviewed
Aug 28, 2025
Comment on lines
113
to
117
| local function emit_event_if_latest_state_missing(device, component, capability, attribute_name, value) | ||
| if device:get_latest_state(component, capability.ID, attribute_name) == nil and device:supports_capability(capability) then | ||
| device:emit_event(value) | ||
| end | ||
| end | ||
|
|
||
| local function emit_component_event_if_latest_state_missing(device, component, capability, attribute_name, value) | ||
| if device:get_latest_state(component.id, capability.ID, attribute_name) == nil and device:supports_capability(capability) then | ||
| device:emit_component_event(component, value) | ||
| end | ||
| end |
There was a problem hiding this comment.
As far as I know, device:emit_event(value) means device:emit_component_event("main", value).
Do we need to divide as two functions?
And let me see the device:emit_component_event()
It seems like the function is already checking supports_capability.
I am not sure we need to check supports capability in these drivers or not? How about you @pInksenberg
There was a problem hiding this comment.
Yes, I agree with you, when calling device:emit_event(value) , it actually calls device:emit_component_event("main", value), which checks supports_capability internally, and I believe that supports_capability can be ignored.
There was a problem hiding this comment.
And I'll combined these two functions into one.
|
can you describe driver list or event list for this PR to commit message in more detail? |
pInksenberg
force-pushed
the
preventing-unnecessary-event-emitting-in-edge-driver
branch
2 times, most recently
from
0a7afb1 to
af6f071
Compare
updated! |
greens
approved these changes
Aug 28, 2025
pInksenberg
force-pushed
the
preventing-unnecessary-event-emitting-in-edge-driver
branch
from
af6f071 to
f678380
Compare
…witch-over.
We add check_latest state before sending initial event(open/unlocked/presense) for following drivers:
- SmartThings/zigbee-contact/src/aqara/
- SmartThings/zigbee-lock/src/samsungsds
- SmartThings/zigbee-presence-sensor/src/arrival-sensor-v1
- SmartThings/zigbee-presence-sensor/src (top-most driver)
- SmartThings/zigbee-thermostat/src/aqara
- SmartThings/zwave-sensor/src/fibaro-door-window-sensor/fibaro-door-window-sensor-1
- SmartThings/zwave-sensor/src/fibaro-door-window-sensor/fibaro-door-window-sensor-2
pInksenberg
force-pushed
the
preventing-unnecessary-event-emitting-in-edge-driver
branch
from
f678380 to
d6c703e
Compare
kdbang
approved these changes
Aug 29, 2025
varzac
approved these changes
Aug 29, 2025
greens
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
There’re VoCs about ZigBee Things reported from Korean Market while user is doing switchover, a device event emitting may be called to initialize device state from edge driver to cloud, so an unexpected routine could be triggered and make user confused.
we change the driver code to avoid emitting unnecessary event during the hub switch-over by checking the latest state, only focus on the important(security related) events, 'open', 'present', 'unlocked'.
Summary of Completed Tests