Skip to content

Add driver support for Matter Cameras #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Add driver support for Matter Cameras #2503

merged 1 commit into from
Nov 14, 2025

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Oct 28, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Test Results

   71 files    468 suites   0s ⏱️
2 455 tests 2 455 ✅ 0 💤 0 ❌
4 168 runs  4 168 ✅ 0 💤 0 ❌

Results for commit 4c39600.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

File Coverage
All files 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/fields.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/embedded_cluster_utils.lua 38% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/utils.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/attribute_handlers.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/capability_handlers.lua 78% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua 83% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/event_handlers.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/utils.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/eve_energy/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_mk1/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua 96% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 4c39600

hcarter-775
hcarter-775 reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@hcarter-775 hcarter-775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an initial review but I figured I'd get these thoughts out there

@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch 2 times, most recently from 66f0b0a to 31c2294 Compare November 4, 2025 20:47
nickolas-deboom
nickolas-deboom commented Nov 4, 2025
View reviewed changes
drivers/SmartThings/matter-switch/src/init.lua
},
supported_capabilities = fields.supported_capabilities,
sub_drivers = {
require("sub_drivers.aqara_cube"),
Copy link
Contributor Author

@nickolas-deboom nickolas-deboom Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lazy loading for other subdrivers is implemented in #2525

@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch from 31c2294 to 5662469 Compare November 4, 2025 20:54
ctowns
ctowns reviewed Nov 11, 2025
View reviewed changes
ctowns
ctowns reviewed Nov 11, 2025
View reviewed changes
ctowns
ctowns reviewed Nov 11, 2025
View reviewed changes
hcarter-775
hcarter-775 reviewed Nov 11, 2025
View reviewed changes
@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch from 7a82290 to 9639115 Compare November 12, 2025 16:37
@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch 2 times, most recently from a797600 to 0c01acf Compare November 13, 2025 20:52
@nickolas-deboom nickolas-deboom changed the title Add driver support for Matter cameras Add driver support for Matter Cameras Nov 13, 2025
@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch 2 times, most recently from b71c0f4 to 0884c38 Compare November 14, 2025 18:09
@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch from 0884c38 to cccb1f8 Compare November 14, 2025 19:59
@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch from cccb1f8 to 17d2cbd Compare November 14, 2025 20:14
@nickolas-deboom nickolas-deboom force-pushed the add-matter-camera-support branch from 17d2cbd to 4c39600 Compare November 14, 2025 20:17
@nickolas-deboom nickolas-deboom merged commit eb90b37 into main Nov 14, 2025
12 checks passed
@nickolas-deboom nickolas-deboom deleted the add-matter-camera-support branch November 14, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctowns ctowns ctowns approved these changes

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@samadDotDev samadDotDev Awaiting requested review from samadDotDev

@z-michel z-michel Awaiting requested review from z-michel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickolas-deboom @ctowns @hcarter-775