Lazy load camera subdriver only for LuaLibs 16 and greater #2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 71 files 468 suites 0s ⏱️ Results for commit aa2d215. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against aa2d215 |
samadDotDev
approved these changes
Nov 17, 2025
hcarter-775
approved these changes
Nov 17, 2025
The camera subdriver is only supported on LuaLibs version >= 16, and causes issues if it's loaded on previous versions, so this commit changes `lazy_load_if_possible` to `lazy_load`, which only attempts to pull in the subdriver if the api version if 16 or greater.
nickolas-deboom
force-pushed
the
lazy-load-camera-subdriver-only-on-api-ge-16
branch
from
bd3e5eb to
aa2d215
Compare
ctowns
approved these changes
Nov 17, 2025
nickolas-deboom
deleted the
lazy-load-camera-subdriver-only-on-api-ge-16
branch
hcarter-775
pushed a commit
that referenced
this pull request
Nov 20, 2025
The camera subdriver is only supported on LuaLibs version >= 16, and causes issues if it's loaded on previous versions, so this commit changes `lazy_load_if_possible` to `lazy_load`, which only attempts to pull in the subdriver if the api version if 16 or greater.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera subdriver is only supported on LuaLibs version >= 16, and causes issues if it's loaded on previous versions, so this commit changes
lazy_load_if_possibletolazy_load, which only attempts to pull in the subdriver if the api version if 16 or greater.Note that
lazy_load_if_possiblewill be reintroduced by #2525 to allow for lazy loading other subdrivers, which do support lower lua libs versions.