Skip to content

Matter Sensor: Allow modular profile updates in infoChanged #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hcarter-775 merged 1 commit into from
Dec 9, 2025
+5 −1
Merged

Matter Sensor: Allow modular profile updates in infoChanged #2615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...nsor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/device_configuration.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ function DeviceConfiguration.match_profile(device)
end

device:try_update_metadata({profile = profile_name, optional_component_capabilities = optional_supported_component_capabilities})
device:set_field(fields.MODULAR_PROFILE_UPDATED, true)

-- earlier modular profile gating (min api v14, rpc 8) ensures we are running >= 0.57 FW.
-- This gating specifies a workaround required only for 0.57 FW, which is not needed for 0.58 and higher.
Expand Down
2 changes: 2 additions & 0 deletions ...ings/matter-sensor/src/sub_drivers/air_quality_sensor/air_quality_sensor_utils/fields.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ local AirQualitySensorFields = {}

AirQualitySensorFields.AIR_QUALITY_SENSOR_DEVICE_TYPE_ID = 0x002C

AirQualitySensorFields.MODULAR_PROFILE_UPDATED = "__modular_profile_updated"

AirQualitySensorFields.SUPPORTED_COMPONENT_CAPABILITIES = "__supported_component_capabilities"

AirQualitySensorFields.units_required = {
Expand Down
3 changes: 2 additions & 1 deletion drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ function AirQualitySensorLifecycleHandlers.device_init(driver, device)
end

function AirQualitySensorLifecycleHandlers.info_changed(driver, device, event, args)
if device.profile.id ~= args.old_st_store.profile.id then
if device.profile.id ~= args.old_st_store.profile.id or device:get_field(fields.MODULAR_PROFILE_UPDATED) then
if device:get_field(fields.SUPPORTED_COMPONENT_CAPABILITIES) then
--re-up subscription with new capabilities using the modular supports_capability override
device:extend_device("supports_capability_by_id", aqs_utils.supports_capability_by_id_modular)
end
device:set_field(fields.MODULAR_PROFILE_UPDATED, nil)
aqs_utils.set_supported_health_concern_values(device)
device:subscribe()
end
Expand Down
Loading