feat: app list options and fixes to app and schema commands #101
Conversation
packages/cli/src/lib/aws-utils.ts
Outdated
| if (!principal) { | ||
| principal = '148790070172' | ||
| } |
There was a problem hiding this comment.
Here too, principal can't be undefined because of the defaulted parameter.
packages/cli/src/lib/aws-utils.ts
Outdated
| if (!principal) { | ||
| principal = '906037444270' | ||
| } | ||
|
|
||
| if (!statementId) { | ||
| statementId = 'smartthings' | ||
| } |
There was a problem hiding this comment.
You actually don't need this because you have the default values. (Even passing a literal undefined as one of the values will use its default.)
There was a problem hiding this comment.
Ha! I was thinking it would behave like a null, but not setting a flag does return undefined, so I removed these for clarity
| principal: flags.string({ | ||
| description: 'use this principal instead of the default when authorizing lambda functions', | ||
| }), | ||
| 'statement-id': flags.string({ | ||
| description: 'use this statement id instead of the default when authorizing lambda functions', | ||
| }), |
There was a problem hiding this comment.
Since these flags are used so often, It might be worth putting these in some common place and ...ing them in so if we need to update the text, we can just do it in one place.
There was a problem hiding this comment.
Good idea. I moved them
| static examples = [ | ||
| '$ smartthings apps:authorize arn:aws:lambda:us-east-1:1234567890:function:your-test-app', | ||
| '', | ||
| 'Note that this command is the same as running the following with the AWS CLI:', | ||
| '', | ||
| '$ aws lambda add-permission --region us-east-1 \\', | ||
| ' --function-name arn:aws:lambda:us-east-1:1234567890:function:your-test-app \\', | ||
| ' --statement-id smartthings --principal 148790070172 --action lambda:InvokeFunction', | ||
| '', | ||
| 'It requires your machine to be configured to run the AWS CLI', | ||
| ] |
There was a problem hiding this comment.
I love that you're including these examples. I need to do that more often.
bflorian
force-pushed
the
app-list-options
branch
from
b42f9d3 to
1806acb
Compare
bflorian
force-pushed
the
app-list-options
branch
from
1806acb to
aa4a737
Compare
2 participants
Several small fixes and enhancements:
appslist command to accept filter parameters.schema:updatewhere list selection wasn't working.