Skip to content

Conversation

@john-u
Copy link
Contributor

@john-u john-u commented May 20, 2022

  • remove Node 12 from CI matrix since it is unsupported

Checklist

  • I have read the CONTRIBUTING document
  • Any required documentation has been added
  • My code follows the code style of this project (npm run lint produces no warnings/errors)
  • I have added tests to cover my changes

@john-u john-u requested review from Sitlintac, bflorian and rossiam May 20, 2022 18:11
@changeset-bot
Copy link

changeset-bot bot commented May 20, 2022

🦋 Changeset detected

Latest commit: a657879

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@smartthings/cli-lib Patch
@smartthings/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@john-u john-u force-pushed the feat-login-debug branch from 462c150 to 18a92ce Compare May 20, 2022 18:34
@john-u john-u changed the title feat: add debug logging to defualt login feat: add debug logging to default login May 20, 2022
strategy:
matrix:
# add/remove versions as we move support forward
node-version: [12.18.1, 14, 16]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might as well also remove 14 at this point.

@john-u john-u force-pushed the feat-login-debug branch from 18a92ce to e09a5e8 Compare May 23, 2022 13:40
- remove Node 12 from CI matrix since it is unsupported
@john-u john-u force-pushed the feat-login-debug branch from e09a5e8 to a657879 Compare May 23, 2022 13:52
@john-u john-u merged commit d4730e0 into SmartThingsCommunity:master May 23, 2022
@john-u john-u deleted the feat-login-debug branch May 23, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants