Skip to content

Conversation

@rossiam
Copy link
Collaborator

@rossiam rossiam commented Jul 21, 2022

  • moved handling of organization command line flag and associated configuration option into APIOrganizationCommand class
  • moved corresponding unit tests
  • updated core SDK version in testlib package (was previously updated in lib and cli packages)

See also SmartThingsCommunity/edge-cli-plugin#52 (draft until this pull request is merged and released).

Checklist

  • I have read the CONTRIBUTING document
  • Any required documentation has been added
  • My code follows the code style of this project (npm run lint produces no warnings/errors)
  • I have added tests to cover my changes

@rossiam rossiam requested review from Sitlintac, bflorian and john-u July 21, 2022 19:52
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

🦋 Changeset detected

Latest commit: cfebf99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@smartthings/cli-lib Patch
@smartthings/cli-testlib Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@john-u john-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a changeset, as it will impact the Edge plugin.

@rossiam rossiam force-pushed the api-org-refactor branch from 759f663 to 37d5330 Compare July 26, 2022 15:02
@rossiam rossiam force-pushed the api-org-refactor branch from 37d5330 to cfebf99 Compare July 26, 2022 15:10
@rossiam
Copy link
Collaborator Author

rossiam commented Jul 26, 2022

This will need a changeset, as it will impact the Edge plugin.

Good catch.

@rossiam rossiam merged commit 47b27d2 into SmartThingsCommunity:master Jul 26, 2022
@rossiam rossiam deleted the api-org-refactor branch July 26, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants