feat: support verbose flag for installedapps and installedschema commands with single item #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ands with single item
🦋 Changeset detectedLatest commit: c1e8bef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rossiam
commented
Sep 8, 2022
Comment on lines
+46
to
49
| config.listTableFieldDefinitions = [...listTableFieldDefinitions] | ||
| config.listTableFieldDefinitions.splice(3, 0, 'locationId', 'location') | ||
| config.tableFieldDefinitions = [...tableFieldDefinitions] | ||
| config.tableFieldDefinitions.splice(5, 0, 'location') |
Collaborator
Author
There was a problem hiding this comment.
The reason I'm duplicating the arrays here before splicing is so we don't modify the original array which breaks unit tests. It might be cleaner to change the arrays in the util class to functions that return the array (as a fresh copy each time) but I figured this is good enough for now.
Sitlintac
approved these changes
Sep 8, 2022
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withLocationto add location to a single item (matches/useswithLocationswhich does the same for a list)InstalledAppWithLocationandInstalledSchemaAppWithLocationin favor ofWithNamedLocationChecklist
npm run lintproduces no warnings/errors)