Fix Example Builds #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Build Process for Example Apps
lurock
reviewed
Sep 8, 2017
scripts/clean.ps1
Outdated
| @@ -0,0 +1,5 @@ | |||
| if (Test-Path "./dist") { | |||
Contributor
There was a problem hiding this comment.
Remove this script or change it to run with node
lurock
reviewed
Sep 8, 2017
example-app-angular-cli/package.json
Outdated
| "playground:fresh": "npm i ../ && npm run playground", | ||
| "playground": "angular-playground", | ||
| "playground2": "angular-playground angular-playground2.json", | ||
| "playground:fresh": "node ../scripts/build-examples.js && npm run playground", |
Contributor
There was a problem hiding this comment.
Remove fresh and just have "npm run playground"
lurock
reviewed
Sep 8, 2017
example-app-angular-cli/README.md
Outdated
| Development Steps: | ||
| 1. `npm i` in root (`angular-playground/`) | ||
| 2. `npm i` in this directory (`example-app-angular-cli`) | ||
| 3. `npm run playground:fresh` |
Contributor
There was a problem hiding this comment.
Change this to "npm run playground"
lurock
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New build process will create the
node_modules/angular-playground/dist/directory andpackage.jsonfile without the extra stuff that was causing errors in the CLI example.To start developing in an example, do the following:
npm iin root,angular-playgroundnpm iin example,angular-playground/example-app-angular-clinpm playground:fresh