Skip to content

Fix duplicate packages in PR descriptions #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
Merged

Fix duplicate packages in PR descriptions #922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff39f6c
fix(fix): deduplicate affected packages in PR descriptions
jdalton Nov 19, 2025
f8fff7d
refactor(fix): DRY out package deduplication with getUniquePackages h…
jdalton Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/commands/fix/git.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,19 @@ import type { GhsaDetails } from '../../utils/github.mts'

const GITHUB_ADVISORIES_URL = 'https://github.com/advisories'

/**
* Extract unique package names with ecosystems from vulnerability details.
*/
function getUniquePackages(details: GhsaDetails): string[] {
return [
...new Set(
details.vulnerabilities.nodes.map(
v => `${v.package.name} (${v.package.ecosystem})`,
),
),
]
}

export type SocketFixBranchParser = (
branch: string,
) => SocketFixBranchParseResult | undefined
Expand Down Expand Up @@ -60,9 +73,7 @@ export function getSocketFixPullRequestBody(
if (!details) {
return body
}
const packages = details.vulnerabilities.nodes.map(
v => `${v.package.name} (${v.package.ecosystem})`,
)
const packages = getUniquePackages(details)
return [
body,
'',
Expand All @@ -82,9 +93,7 @@ export function getSocketFixPullRequestBody(
const details = ghsaDetails?.get(id)
const item = `- [${id}](${GITHUB_ADVISORIES_URL}/${id})`
if (details) {
const packages = details.vulnerabilities.nodes.map(
v => `${v.package.name}`,
)
const packages = getUniquePackages(details)
return `${item} - ${details.summary} (${joinAnd(packages)})`
}
return item
Expand Down