Skip to content

🐛 Fix mkdir bug for local-provider #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021
Merged

🐛 Fix mkdir bug for local-provider #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/features/upload-file/providers/local-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,22 @@ export class LocalProvider extends BaseProvider {
}

public async upload(file: UploadedFile, key: string): Promise<any> {
const filePath = this.path(key)
await fs.promises.mkdir(path.dirname(filePath), { recursive: true })
await fs.promises.rename(file.path, filePath)
const filePath = process.platform === 'win32'
? this.path(key) : this.path(key).slice(1); // adjusting file path according to OS

await fs.promises.mkdir(path.dirname(filePath), { recursive: true });
await fs.promises.rename(file.path, filePath);
}

public async delete(key: string, bucket: string): Promise<any> {
await fs.promises.unlink(this.path(key, bucket))
await fs.promises.unlink(process.platform === 'win32'
? this.path(key, bucket) : this.path(key, bucket).slice(1)); // adjusting file path according to OS
}

// eslint-disable-next-line class-methods-use-this
public path(key: string, bucket?: string): string {
return `/${path.join(bucket || this.bucket, key)}`
// Windows doesn't requires the '/' in path, while UNIX system does
return process.platform === 'win32' ? `${path.join(bucket || this.bucket, key)}`
: `/${path.join(bucket || this.bucket, key)}`;
}
}